You are browsing a read-only backup copy of Wikitech. The primary site can be found at wikitech.wikimedia.org

User talk:QChris

From Wikitech-static
Jump to navigation Jump to search

Welcome to Tool Labs

Hello QChris, welcome to the Tool Labs project! Your request for access was processed and you should be able to login now via ssh at tools-login.wmflabs.org. To get started, check the help page and the migrating from the Toolserver page. You can also ask in our IRC channel at #wikimedia-labs connect or send an e-mail to our mailing list labs-l@lists.wikimedia.org – thank you, and have fun using Tools! Tim Landscheidt (talk) 14:38, 17 May 2014 (UTC)

Completing project documentation

This is regarding the announcement (http://lists.wikimedia.org/pipermail/labs-l/2014-July/002762.html) if you have missed it.

We have added some fields in addition to description field which is already there on your projects. Please click "Edit Documentation" in your project page/ project pages and fill the blanks. It will only take few minutes from your valuable time.

If you have any comments or suggestion on the form please let me know.--Sandaru (talk) 10:41, 26 July 2014 (UTC)

Yes Done qchris (talk) 17:33, 1 August 2014 (UTC)

Access rights to extension

Hey Chris,

Sorry to bother you. You helped me out the other day by creating a repository for my extension and created the initial code review commit. I'm trying to follow the instructions for the Gerrit/Tutorial.

When I try the command for git review -R I get this:

fatal: 'sorvis@gerrit.wikimedia.org/r/mediawiki/extensions/SearchStats' does not appear to be a git repository

fatal: Could not read from remote repository.

Is there something else I need to do or are my permissions not quite right?

Thank you for your help!

@Sorvis: The URL you pasted looks wrong. It looks like the repository's URL for anonymous access, but has a username. So maybe you cloned from the wrong URL? In the longish grey line above the git clone command on https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/SearchStats be sure to select ssh. That should give you a working SSH URL for git.
Just to make sure the repo is working fine, I made a demo change to the repo (and of course abandoned it again). Here's the step-by-step command log and output. If that choin of commands fails for you, let me know at which step and what error message you get. (Obviously replace qchris by your user name)
________________________________________________________________________________
christian@spencer // jobs: 0 // timestamp: 2016-09-15T20:14:43Z // exit code: 0
cwd: ~/tmp
git clone ssh://qchris@gerrit.wikimedia.org:29418/mediawiki/extensions/SearchStats       # Initial cloning
Cloning into 'SearchStats'...
remote: Total 3 (delta 0), reused 3 (delta 0)
Receiving objects: 100% (3/3), done.

________________________________________________________________________________
christian@spencer // jobs: 0 // timestamp: 2016-09-15T20:14:47Z // exit code: 0
cwd: ~/tmp
cd SearchStats/                                                                         # Moving into the clone's directory

________________________________________________________________________________
christian@spencer // jobs: 0 // timestamp: 2016-09-15T20:14:52Z // exit code: 0
cwd: ~/tmp/SearchStats
git review -s                                                                           # Setting up git review
Creating a git remote called "gerrit" that maps to:
        ssh://qchris@gerrit.wikimedia.org:29418/mediawiki/extensions/SearchStats.git

________________________________________________________________________________
christian@spencer // jobs: 0 // timestamp: 2016-09-15T20:15:13Z // exit code: 0
cwd: ~/tmp/SearchStats
git pull origin master                                                                  # Updating master
From ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SearchStats
 * branch            master     -> FETCH_HEAD
Already up-to-date.

________________________________________________________________________________
christian@spencer // jobs: 0 // timestamp: 2016-09-15T20:15:34Z // exit code: 0
cwd: ~/tmp/SearchStats
git checkout -b qchris-demo-for-sorvis                                                  # Creating named working branch.
Switched to a new branch 'qchris-demo-for-sorvis'

________________________________________________________________________________
christian@spencer // jobs: 0 // timestamp: 2016-09-15T20:15:57Z // exit code: 0
cwd: ~/tmp/SearchStats
echo "foo" >foo                                                                         # Just some random change

________________________________________________________________________________
christian@spencer // jobs: 0 // timestamp: 2016-09-15T20:16:02Z // exit code: 0
cwd: ~/tmp/SearchStats
git add foo                                                                             # Adding the changed file

________________________________________________________________________________
christian@spencer // jobs: 0 // timestamp: 2016-09-15T20:16:12Z // exit code: 0
cwd: ~/tmp/SearchStats
git commit -m "DO NOT MERGE. Demo commit for Sorvis"                                    # Commiting the change
[qchris-demo-for-sorvis 38ecb9e] DO NOT MERGE. Demo commit for Sorvis
 1 file changed, 1 insertion(+)
 create mode 100644 foo

________________________________________________________________________________
christian@spencer // jobs: 0 // timestamp: 2016-09-15T20:16:35Z // exit code: 0
cwd: ~/tmp/SearchStats
git review -R                                                                           # Using git review to get the change to gerrit
remote: Processing changes: new: 1, refs: 1, done    
remote: 
remote: New Changes:
remote:   https://gerrit.wikimedia.org/r/310950 DO NOT MERGE. Demo commit for Sorvis
remote: 
To ssh://qchris@gerrit.wikimedia.org:29418/mediawiki/extensions/SearchStats.git
 * [new branch]      HEAD -> refs/publish/master/qchris-demo-for-sorvis
Corresponding (meanwhile abandoned) change is at https://gerrit.wikimedia.org/r/#/c/310950/1
@QChris :

Thank you Chris, for your example instructions that worked for me. I was using a https remote instead of ssh.

I was able to get my code into to gerrit at https://gerrit.wikimedia.org/r/#/c/311684/

If I understand the process correctly I should have rights to approve code, is that true? I'm not seeing a approve code button on the page.

@Sorvis: Sorry for the delay. Yes, I double-checked. You're having the necessary permissions needed to merge the Code. With the new Gerrit (get installed a few weeks back), there is now no longer a button to approve visible right away. First you need to collect votes (either your own or others) on the commit. To vote on a commit, click the "Reply" button in the middle of the top grey bar on https://gerrit.wikimedia.org/r/#/c/311684/ . In the pop-up window, you can vote on "Code-Review" and "Verified" . In order to land a change, you first need to have at least a "+2" vote on "Code-Review" and a "+1" vote on "Verified". --qchris (talk) 12:03, 26 September 2016 (UTC)
@QChris : That did the trick! Thank you Chris. Sorvis (talk) 11:45, 27 September 2016 (UTC)
Yes Done Yay! Perfect! --qchris (talk) 15:39, 27 September 2016 (UTC)