You are browsing a read-only backup copy of Wikitech. The primary site can be found at wikitech.wikimedia.org

Technical debt/Unused config: Difference between revisions

From Wikitech-static
Jump to navigation Jump to search
imported>Krinkle
mNo edit summary
imported>Jforrester
(Two WikiLambda ones now removed.)
 
(5 intermediate revisions by 3 users not shown)
Line 1: Line 1:
For the script that detects '''unused variables in wmf-config''', see [[git:mediawiki/tools/code-utils/+/HEAD/|wmf-config-wg-vars.mjs in mediawiki/tools/code-utils.git]]
This page reports '''unused configuration variables''' in wmf-config, as generated by [[git:mediawiki/tools/code-utils/+/HEAD/|wmf-config-wg-vars.mjs in mediawiki/tools/code-utils.git]]. See prior work at [https://wikitech.wikimedia.org/w/index.php?title=Technical_debt/Unused_config&oldid=1814269#Resolved one], [https://wikitech.wikimedia.org/w/index.php?title=Technical_debt/Unused_config&oldid=1815001 two].


Resolved items are removed in batches. See prior work at [https://wikitech.wikimedia.org/w/index.php?title=Technical_debt/Unused_config&oldid=1814269#Resolved one], [https://wikitech.wikimedia.org/w/index.php?title=Technical_debt/Unused_config&oldid=1815001 two]. __NONEWSECTIONLINK__
== Reminder ==
Please '''do not propose mass removal''' via a configuration patch without involving relevant code owners. These results represent very low priority technical debt that does no harm to remain.  


Last updated: --[[User:Krinkle|Krinkle]] ([[User talk:Krinkle|talk]]) 01:08, 4 August 2022 (UTC)
It serves as a useful prompt and reminder to review an extension's configuration values, an opportunity to on-board team mates or otherwise exercise and familiarise oneself with maintenance duties.
 
Issues to consider:
 
* The unused variable may be indicative of an incomplete migration, e.g. perhaps some other variable needs to be added to replace it, or some database migration has yet to be run.
* The variable may be defined with a typo/spelling mistake and actually needs to be corrected instead of removed.
* The query to [[mw:Codesearch|Codesearch]] may have missed actual usage, e.g via computed or concatenated strings passed to <code>Config->get()</code>.
* It is not uncommon that we deploy technically-unused variables a few weeks ahead before an accompanying feature is deployed, to prevent errors during launch.
 
== Results ==
__NONEWSECTIONLINK__
 
Results were last generated: --[[User:Krinkle|Krinkle]] ([[User talk:Krinkle|talk]]) 01:08, 4 August 2022 (UTC)


{| class="wikitable sortable"
{| class="wikitable sortable"
Line 20: Line 33:
|<code>CentralAuthCookiesP3P</code>
|<code>CentralAuthCookiesP3P</code>
|<code>CommonSettings.php</code>
|<code>CommonSettings.php</code>
|
| CentralAuth
|
| [[gerrit:820441|removed]]
|-
|-
|<code>CirrusSearchDropDelayedJobsAfter</code>
|<code>CirrusSearchDropDelayedJobsAfter</code>
Line 56: Line 69:
|<code>EnableMWSuggest</code>
|<code>EnableMWSuggest</code>
|<code>InitialiseSettings.php</code>
|<code>InitialiseSettings.php</code>
|
|core
|
|[[gerrit:c/operations/mediawiki-config/+/820533|removing]]
|-
|-
|<code>FlowMaintenanceMode</code>
|<code>FlowMaintenanceMode</code>
Line 72: Line 85:
|<code>IPInfoGeoIP2Prefix</code>
|<code>IPInfoGeoIP2Prefix</code>
|<code>InitialiseSettings-labs.php</code>
|<code>InitialiseSettings-labs.php</code>
|
|IPInfo
|
|[[gerrit:c/operations/mediawiki-config/+/828482/|removing]]
|-
|-
|<code>IncludejQueryMigrate</code>
|<code>IncludejQueryMigrate</code>
|<code>InitialiseSettings.php</code>
|<code>InitialiseSettings.php</code>
|
|core
|
|[[gerrit:820404|removed]]
|-
|-
|<code>LDAPLowerCaseUsernameScheme</code>
|<code>LDAPLowerCaseUsernameScheme</code>
|<code>wikitech.php</code>
|<code>wikitech.php</code>
|
|
|
|[[gerrit:820255|removed]]
|-
|-
|<code>LDAPUseFetchedUsername</code>
|<code>LDAPUseFetchedUsername</code>
|<code>wikitech.php</code>
|<code>wikitech.php</code>
|
|
|
|[[gerrit:820255|removed]]
|-
|<code>LanguageCodeHasNotBeenSet</code>
|<code>tests/multiversion/StaticSettingsGenerationTest.php</code>
|
|
|-
|-
|<code>LegacyJavaScriptGlobals</code>
|<code>LegacyJavaScriptGlobals</code>
|<code>InitialiseSettings-labs.php</code>
|<code>InitialiseSettings-labs.php</code>
<code>InitialiseSettings.php</code>
<code>InitialiseSettings.php</code>
|
|core
|
|[[gerrit:820402|removed]]
|-
|-
|<code>MFAppPackageId</code>
|<code>MFAppPackageId</code>
Line 108: Line 116:
|<code>MathUseRestBase</code>
|<code>MathUseRestBase</code>
|<code>CommonSettings-labs.php</code>
|<code>CommonSettings-labs.php</code>
|
|Math
|
|[[gerrit:820454|removed]]
|-
|-
|<code>MediaInfoMediaSearchConceptChipsSimpleHeuristics</code>
|<code>MediaInfoMediaSearchConceptChipsSimpleHeuristics</code>
Line 139: Line 147:
|<code>MediaViewerNetworkPerformanceSamplingFactor</code>
|<code>MediaViewerNetworkPerformanceSamplingFactor</code>
|<code>InitialiseSettings-labs.php</code>
|<code>InitialiseSettings-labs.php</code>
|
|MediaViewer
|
|[[gerrit:820389|removed]]
|-
|<code>MemCacheServers</code>
|<code>tests/data/MWDefines.php</code>
|
|
|-
|-
|<code>MinervaShowShareButton</code>
|<code>MinervaShowShareButton</code>
Line 169: Line 172:
|<code>NotificationReplyName</code>
|<code>NotificationReplyName</code>
|<code>CommonSettings.php</code>
|<code>CommonSettings.php</code>
|
| rowspan="3" |Echo
|
| rowspan="3" |[[phab:T314604|T314604]]
|-
|-
|<code>NotificationSender</code>
|<code>NotificationSender</code>
|<code>CommonSettings.php</code>
|<code>CommonSettings.php</code>
|
|
|-
|-
|<code>NotificationSenderName</code>
|<code>NotificationSenderName</code>
|<code>CommonSettings.php</code>
|<code>CommonSettings.php</code>
|
|
|-
|-
|<code>ParserConf</code>
|<code>ParserConf</code>
Line 209: Line 208:
|<code>SFSIPListLocationMD5</code>
|<code>SFSIPListLocationMD5</code>
|<code>CommonSettings-labs.php</code>
|<code>CommonSettings-labs.php</code>
|
|StopForumSpam
|
|[[gerrit:820254|fixed]]
|-
|-
|<code>ShowIPinHeader</code>
|<code>ShowIPinHeader</code>
|<code>CommonSettings.php</code>
|<code>CommonSettings.php</code>
|
|core
|
|
|-
|-
Line 244: Line 243:
|<code>WBCSDefaultPrefixRescoreProfile</code>
|<code>WBCSDefaultPrefixRescoreProfile</code>
|<code>SearchSettingsForWikidata.php</code>
|<code>SearchSettingsForWikidata.php</code>
|
|WikibaseCirrusSearch
|
|false positive
|-
|-
|<code>WBCSEnableDispatchingQueryBuilder</code>
|<code>WBCSEnableDispatchingQueryBuilder</code>
|<code>SearchSettingsForSDC.php</code>
|<code>SearchSettingsForSDC.php</code>
|
|WikibaseCirrusSearch
|
|[[gerrit:820397|removed]]
|-
|-
|<code>WBCSFulltextSearchProfile</code>
|<code>WBCSFulltextSearchProfile</code>
|<code>SearchSettingsForWikidata.php</code>
|<code>SearchSettingsForWikidata.php</code>
|
|WikibaseCirrusSearch
|
|false positive
|-
|-
|<code>WBCSFulltextSearchProfiles</code>
|<code>WBCSFulltextSearchProfiles</code>
|<code>SearchSettingsForWikidata.php</code>
|<code>SearchSettingsForWikidata.php</code>
|
|WikibaseCirrusSearch
|
|false positive
|-
|-
|<code>WBCSLanguageSelectorPrefixSearchProfile</code>
|<code>WBCSLanguageSelectorPrefixSearchProfile</code>
|<code>SearchSettingsForWikidata.php</code>
|<code>SearchSettingsForWikidata.php</code>
|
|WikibaseCirrusSearch
|
|false positive
|-
|-
|<code>WBCSLanguageSelectorRescoreFunctionChains</code>
|<code>WBCSLanguageSelectorRescoreFunctionChains</code>
|<code>SearchSettingsForWikidata.php</code>
|<code>SearchSettingsForWikidata.php</code>
|
|WikibaseCirrusSearch
|
|false positive
|-
|-
|<code>WBCSLanguageSelectorRescoreProfile</code>
|<code>WBCSLanguageSelectorRescoreProfile</code>
|<code>SearchSettingsForWikidata.php</code>
|<code>SearchSettingsForWikidata.php</code>
|
|WikibaseCirrusSearch
|
|false positive
|-
|-
|<code>WBCSLanguageSelectorStatementBoost</code>
|<code>WBCSLanguageSelectorStatementBoost</code>
|<code>SearchSettingsForWikibase.php</code>
|<code>SearchSettingsForWikibase.php</code>
|
|WikibaseCirrusSearch
|
|false positive
|-
|-
|<code>WBCSPrefixSearchProfiles</code>
|<code>WBCSPrefixSearchProfiles</code>
|<code>SearchSettingsForWikidata.php</code>
|<code>SearchSettingsForWikidata.php</code>
|
|WikibaseCirrusSearch
|
|false positive
|-
|-
|<code>WBCSRescoreFunctionChains</code>
|<code>WBCSRescoreFunctionChains</code>
|<code>SearchSettingsForWikidata.php</code>
|<code>SearchSettingsForWikidata.php</code>
|
|WikibaseCirrusSearch
|
|false positive
|-
|-
|<code>WBCSRescoreProfiles</code>
|<code>WBCSRescoreProfiles</code>
|<code>SearchSettingsForWikidata.php</code>
|<code>SearchSettingsForWikidata.php</code>
|
|WikibaseCirrusSearch
|
|false positive
|-
|-
|<code>WMESearchRelevancePages</code>
|<code>WMESearchRelevancePages</code>
|<code>InitialiseSettings.php</code>
|<code>InitialiseSettings.php</code>
|
|
|
|[[gerrit:c/operations/mediawiki-config/+/824685/|removing]]
|-
|-
|<code>WikiLambdaEvaluatorLocation</code>
|<code>WikiLambdaEvaluatorLocation</code>
|<code>CommonSettings.php</code>
|<code>CommonSettings.php</code>
|
|
|
|[[gerrit:c/operations/mediawiki-config/+/820459|removed]]
|-
|-
|<code>WikiLambdaWikiAPILocation</code>
|<code>WikiLambdaWikiAPILocation</code>
|<code>CommonSettings.php</code>
|<code>CommonSettings.php</code>
|
|
|
|[[gerrit:c/operations/mediawiki-config/+/820459|removed]]
|}
|}

Latest revision as of 20:22, 19 September 2022

This page reports unused configuration variables in wmf-config, as generated by wmf-config-wg-vars.mjs in mediawiki/tools/code-utils.git. See prior work at one, two.

Reminder

Please do not propose mass removal via a configuration patch without involving relevant code owners. These results represent very low priority technical debt that does no harm to remain.

It serves as a useful prompt and reminder to review an extension's configuration values, an opportunity to on-board team mates or otherwise exercise and familiarise oneself with maintenance duties.

Issues to consider:

  • The unused variable may be indicative of an incomplete migration, e.g. perhaps some other variable needs to be added to replace it, or some database migration has yet to be run.
  • The variable may be defined with a typo/spelling mistake and actually needs to be corrected instead of removed.
  • The query to Codesearch may have missed actual usage, e.g via computed or concatenated strings passed to Config->get().
  • It is not uncommon that we deploy technically-unused variables a few weeks ahead before an accompanying feature is deployed, to prevent errors during launch.

Results

Results were last generated: --Krinkle (talk) 01:08, 4 August 2022 (UTC)

Param Filename Component Status
AllowMicrodataAttributes InitialiseSettings.php
ArticlePlaceholderSearchIntegrationBackend InitialiseSettings.php
CentralAuthCookiesP3P CommonSettings.php CentralAuth removed
CirrusSearchDropDelayedJobsAfter InitialiseSettings.php

CirrusSearch-production.php

CirrusSimilarityProfiles InitialiseSettings.php
CodeEditorEnableCore CommonSettings.php
DBsqlpassword private/readme.php
EnableCreativeCommonsRdf CommonSettings.php
EnableLocalTimedText CommonSettings.php
EnableMWSuggest InitialiseSettings.php core removing
FlowMaintenanceMode CommonSettings.php
GECampaignPattern InitialiseSettings-labs.php

InitialiseSettings.php

IPInfoGeoIP2Prefix InitialiseSettings-labs.php IPInfo removing
IncludejQueryMigrate InitialiseSettings.php core removed
LDAPLowerCaseUsernameScheme wikitech.php removed
LDAPUseFetchedUsername wikitech.php removed
LegacyJavaScriptGlobals InitialiseSettings-labs.php

InitialiseSettings.php

core removed
MFAppPackageId InitialiseSettings.php
MathUseRestBase CommonSettings-labs.php Math removed
MediaInfoMediaSearchConceptChipsSimpleHeuristics InitialiseSettings.php
MediaInfoMediaSearchDefaultForAnon InitialiseSettings.php
MediaInfoMediaSearchHasLtrPlugin InitialiseSettings.php
MediaInfoMediaSearchProperties InitialiseSettings-labs.php

InitialiseSettings.php

MediaSearchDefaultForAnon InitialiseSettings.php
MediaViewerNetworkPerformanceSamplingFactor InitialiseSettings-labs.php MediaViewer removed
MinervaShowShareButton InitialiseSettings-labs.php
MwEmbedModuleConfig CommonSettings-labs.php
NoticeFundraisingUrl CommonSettings.php
NoticeReporterDomains CommonSettings.php
NotificationReplyName CommonSettings.php Echo T314604
NotificationSender CommonSettings.php
NotificationSenderName CommonSettings.php
ParserConf InitialiseSettings.php
PopupsEventLogging InitialiseSettings.php
ProxyKey private/readme.php
RedirectScript CommonSettings.php
RelatedArticlesLoggingBucketSize CommonSettings.php
SFSIPListLocationMD5 CommonSettings-labs.php StopForumSpam fixed
ShowIPinHeader CommonSettings.php core
StatsMethod InitialiseSettings.php
TimelineEpochTimestamp InitialiseSettings.php
TmhWebPlayer CommonSettings.php
TranslateClustersAndMirrors CommonSettings.php
TranslateDelayedMessageIndexRebuild CommonSettings.php
WBCSDefaultPrefixRescoreProfile SearchSettingsForWikidata.php WikibaseCirrusSearch false positive
WBCSEnableDispatchingQueryBuilder SearchSettingsForSDC.php WikibaseCirrusSearch removed
WBCSFulltextSearchProfile SearchSettingsForWikidata.php WikibaseCirrusSearch false positive
WBCSFulltextSearchProfiles SearchSettingsForWikidata.php WikibaseCirrusSearch false positive
WBCSLanguageSelectorPrefixSearchProfile SearchSettingsForWikidata.php WikibaseCirrusSearch false positive
WBCSLanguageSelectorRescoreFunctionChains SearchSettingsForWikidata.php WikibaseCirrusSearch false positive
WBCSLanguageSelectorRescoreProfile SearchSettingsForWikidata.php WikibaseCirrusSearch false positive
WBCSLanguageSelectorStatementBoost SearchSettingsForWikibase.php WikibaseCirrusSearch false positive
WBCSPrefixSearchProfiles SearchSettingsForWikidata.php WikibaseCirrusSearch false positive
WBCSRescoreFunctionChains SearchSettingsForWikidata.php WikibaseCirrusSearch false positive
WBCSRescoreProfiles SearchSettingsForWikidata.php WikibaseCirrusSearch false positive
WMESearchRelevancePages InitialiseSettings.php removing
WikiLambdaEvaluatorLocation CommonSettings.php removed
WikiLambdaWikiAPILocation CommonSettings.php removed