You are browsing a read-only backup copy of Wikitech. The live site can be found at wikitech.wikimedia.org

Incident documentation/2017-01-24 WikibaseClient-InterwikiSorting: Difference between revisions

From Wikitech-static
Jump to navigation Jump to search
imported>Krinkle
 
imported>Krinkle
 
Line 1: Line 1:
== Summary ==
#REDIRECT [[Incidents/2017-01-24 WikibaseClient-InterwikiSorting]]
Due to an [https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/client/includes/Hooks/InterwikiSortingHookHandlers.php;4e65b466d3e6ce8f5823dc858f917ab5f28ebff0$45 automatic switch in WikibaseClient] adding configuration for the [[mw:Extension:InterwikiSorting|InterwikiSorting extension]] caused Wikibase to start using it in production.
 
This wouldn't have been an issue, except WikibaseClient only checks for one setting [https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/client/includes/Hooks/InterwikiSortingHookHandlers.php;4e65b466d3e6ce8f5823dc858f917ab5f28ebff0$65 but uses 4].
 
One of these settings [https://gerrit.wikimedia.org/r/#/c/333600/ no longer exists in the extension] and was thus not included in the config change.
 
Fatals on all wikis using WikibaseClient for about 3 minutes where the parser cache was missed and getParserOutput was thus called.
 
Although mwdebug1002 was checked, the issue was not spotted, probably due to the issue only arising on getParserOutput calls, cached output would not expose the error.
 
== Timeline ==
 
* 12:12 [[gerrit:333882|Copy InterwikiSorting settings from wmgWikibaseClientSettings]] merged by jenkins
* 12:13 addshore@mwdebug1002 scap pull
* 12:14 addshore@tin: Synchronized wmf-config/InitialiseSettings.php: [[phab:T155995|T155995]] [[gerrit:333882{{!}}Copy InterwikiSorting settings from wmgWikibaseClientSettings]] noop (duration: 00m 39s)
* 12:17 addshore@tin: Synchronized wmf-config/InitialiseSettings.php: Revert last (duration: 00m 39s)
* 12:19 Reported as https://phabricator.wikimedia.org/T156123
* 12:26 [[gerrit:333895|Revert "Copy InterwikiSorting settings from wmgWikibaseClientSettings"]] added to gerrit
 
== Actionables ==
* Do not use wgInterwikiSortingAlwaysSort in WikibaseClient ({{Bug|T156128}}) {{gerrit|333932}}
* Check all config options used... {{gerrit|333933}}
 
{{#ifeq:{{SUBPAGENAME}}|Report Template||
[[Category:Incident documentation]]
}}

Latest revision as of 17:45, 8 April 2022